WIP Update security-getting-started-tutorial from QE feedback #45686
+12
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! Your pull request does not follow our editorial rules. Could you have a look?
This message is automatically generated by a bot. |
quarkus-bot
bot
added
area/docstyle
rolfedh
changed the title
|
I'm not sure we need to add file path locations, users do no create those files manually, making sure the directory structure matches the package name, they put it into IDE and IDE creates everything for them. |
|
🎊 PR Preview fc7985e has been successfully built and deployed to https://quarkus-pr-main-45686-preview.surge.sh/version/main/guides/
|
jedla97
reviewed
Jan 17, 2025
| @@ -495,7 +502,8 @@ Dev Services for PostgreSQL supports testing while you develop by providing a se | |||
|
|
|||
| == Test your application in production mode by using Curl or browser | |||
|
|
|||
| To test your application using Curl or the browser, you must first start a PostgreSQL server, then compile and run your application either in JVM or native mode. | |||
| To test your application using Curl, a browser, or the `quarkus dev` command, start a PostgreSQL server first. | |||
There was a problem hiding this comment.
I think thequarkus dev command should not be used here. As this is testing in production mode.
Suggested change
| To test your application using Curl, a browser, or the `quarkus dev` command, start a PostgreSQL server first. | |
| To test your application using Curl, or a browser, start a PostgreSQL server first. |
Co-authored-by: Jakub Jedlička <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update security-getting-started-tutorial from QE feedback.